-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean node resolver map entries on attested node deletion #3873
Clean node resolver map entries on attested node deletion #3873
Conversation
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @guilhermocc! I wonder if we should open a separate issue to provide some database cleanup code that deletes selector rows that have a spiffe ID not represented in the attested nodes table, maybe when the database is first opened, that we could keep in for a minor release cycle to make sure stale entries are removed eventually.
It makes sense since this PR will only prevent the existence of new stale node resolver map entries, but will not clean existing ones. I can create it :) |
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Pull Request check list
Affected functionality
Description of change
Update
DeleteAttestedNode
method to also delete node selectorsWhich issue this PR fixes
fixes #3872