Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a gauge metric for the spire-server entry cache size #4720

Closed
stevend-uber opened this issue Dec 7, 2023 · 7 comments
Closed

Introduce a gauge metric for the spire-server entry cache size #4720

stevend-uber opened this issue Dec 7, 2023 · 7 comments
Assignees
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Milestone

Comments

@stevend-uber
Copy link
Contributor

stevend-uber commented Dec 7, 2023

It would be valuable for spire users to be able to easily query how large in-memory cache size is at a metric's glance over time.

@edwbuck
Copy link
Contributor

edwbuck commented Dec 12, 2023

What units are you expecting? (size in number of entries, size in bytes / kb, etc.)

@azdagron azdagron added triage/in-progress Issue triage is in progress help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog and removed triage/in-progress Issue triage is in progress labels Dec 12, 2023
@azdagron
Copy link
Member

Seems very reasonable to add a bunch of metrics around the internal cache details.

@stevend-uber
Copy link
Contributor Author

Off the top of my head:

  • Entry Counts
  • Size in bytes

@tburko
Copy link

tburko commented Feb 29, 2024

one could build an alert based on the difference between actual entries and expected and hopefully get a heads up before rotations start to fail en masse

@edwbuck edwbuck mentioned this issue Jun 4, 2024
3 tasks
@edwbuck
Copy link
Contributor

edwbuck commented Jun 4, 2024

Let's extend this to include missing event gauge

@stevend-uber
Copy link
Contributor Author

@azdagron You can assign this issue to me. I think I can get to this in July :)

@azdagron
Copy link
Member

Super! Thanks, @stevend-uber !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Development

No branches or pull requests

5 participants