Add gauge metrics to track missedEvents and cache sizes #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevend-uber
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
stevend-uber
force-pushed
the
stevend/gauge
branch
2 times, most recently
from
342c902 to
21feef9
Compare
edwbuck
suggested changes
Aug 20, 2024
There was a problem hiding this comment.
This heavily uses the word "missed" which in my mind implies that we forgot something; because, one only misses items that exist (or existed).
I would prefer using the word "skipped" as there are scenarios where we should skip event ids, because the events associated with them never were created (due to hung transactions that never completed, or autoincrement values that don't increase by one).
Also, we need updates to doc/telemetry/telemetry.md.
stevend-uber
force-pushed
the
stevend/gauge
branch
6 times, most recently
from
35ccd20 to
53f5776
Compare
edwbuck
approved these changes
Aug 20, 2024
stevend-uber
force-pushed
the
stevend/gauge
branch
from
53f5776 to
cadd672
Compare
zmt
approved these changes
Aug 21, 2024
stevend-uber
force-pushed
the
stevend/gauge
branch
2 times, most recently
from
a219c7e to
68047c5
Compare
Signed-off-by: stevend <stevend@uber.com>
stevend-uber
force-pushed
the
stevend/gauge
branch
from
68047c5 to
8988214
Compare
amartinezfayo
approved these changes
Aug 27, 2024
amartinezfayo
added a commit
that referenced
this pull request
Aug 27, 2024
Signed-off-by: stevend <stevend@uber.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics for the event-based cache. This will emit a gauge whenever the cache is updated for missed-events and current cache sizes.
Pull Request check list
Which issue this PR fixes
#4720