Cache bundles in node handler #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node API FetchX509SVID RPC is called aggressively by agents. One of the responsibilities is to fetch bundle information for the agents. This results in large QPS on the database for a resource that does not change frequently. This change introduces a small bundle cache to the node handler with one second invalidation. Bundle caching has an impact on the smallest rotatable SVID TTL since it influences how fast a prepared but unactivated CA certificate is propogated. In normal usage scenarios, the SVID TTLs should be large enough that there should be no practical impact. However, the rotation integration test, which is very tightly coupled with rotation timing, needed a small bump in CA and SVID TTLs to accomodate the caching. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
marcosy
as code owners
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node API FetchX509SVID RPC is called aggressively by agents. One of the responsibilities is to fetch bundle information for the agents. This results in large QPS on the database for a resource that does not change frequently. This change introduces a small bundle cache to the node
handler with one second invalidation.
Fixes #1342