Tolerate slightly stale results in authorized entry crawl #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erations if read DB Connections are provided. The tolerateStale is enabled by default for these operations in node handlers. If the server is not configured with readOnly DB connections, the reads are defaulted to primary readWrite DB instances. Signed-off-by: Kirutthika Raja <kirutthika.raja@uber.com>
kirutthika
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
marcosy
as code owners
3 tasks
azdagron
reviewed
Feb 11, 2020
azdagron
changed the title
…down from FetchRegistrationEntries. Signed-off-by: Kirutthika Raja <kirutthika.raja@uber.com>
Thanks @azdagron, addressed the comments with the latest diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling reads across GetNodeSelectors and ListRegistrationEntries operations if read DB Connections are provided.
The tolerateStale is enabled by default for these operations in node handlers. If the server is not configured with readOnly DB connections, the reads are defaulted to primary readWrite DB instances.
Signed-off-by: Kirutthika Raja kirutthika.raja@uber.com
Pull Request check list
Affected functionality
Enabling read operations across read replicas by turning on the tolerateStale flag.
Description of change
Enabling reads across GetNodeSelectors and ListRegistrationEntries operations if read DB Connections are provided.
The tolerateStale is enabled by default for these operations in node handlers. If the server is not configured with readOnly DB connections, the reads are defaulted to primary readWrite DB instances.
Which issue this PR fixes
#1239