Bump to go1.14.4 #1722
Merged
Bump to go1.14.4 #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
mcpherrinm
as code owners
We put off moving to go1.14+ to give time things to settle related to the (largely patched) kernel bug that go1.14 tickles more due to the signals generated by the preemptive scheduler (see golang/go#35777). There is a small risk of unpatched kernels out there. Also, go1.15 comes out in roughly a month and we'll need to move to at least go1.14 by then to continue to get security updates (since go1.13.x will no longer be maintained). We've watched the ecosystem and waited for large infrastructure products to move to go1.14. Kubernetes and etcd, among others, have made the plunge. Now feels like a good time. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
When the go version gets bumped, the tools built via go are not rebuilt with the new version. This can cause subtle breakages like small updates to the gofmt. This change fixes the Makefile to properly rebuild the tools if they aren't built with the correct version. It also updates a few generated protobuf code files that changed due to formatting with go1.14.4. Signed-off-by: Andrew Harding <andrew.harding@hpe.com>
amartinezfayo
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We put off moving to go1.14+ to give time for things to settle related to the (largely patched) kernel bug that go1.14 tickles more due to the signals generated by the preemptive scheduler (see golang/go#35777).
There is a small risk of unpatched kernels out there.
Also, go1.15 comes out in roughly a month and we'll need to move to at least go1.14 by then to continue to get security updates (since go1.13.x will no longer be maintained).
We've watched the ecosystem and waited for large infrastructure products to move to go1.14. Kubernetes and etcd, among others, have made the plunge.
Now feels like a good time.