Fix workload attestation for K8s 1.21+ #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.21 seems to use cgroups namespaces differently than 1.20. This breaks assumptions in the K8s workload attestor about how the paths of the cgroups are shaped which prevents the attestor from locating the pod/container of the process under attestation. This change relaxes the regular expression to not expect the cgroup paths we use to identify the pod/container to be expressely under a kubepods prefix. Fixes: spiffe#2578 Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
rturner3
as code owners
Signed-off-by: Andrew Harding <aharding@vmware.com>
Signed-off-by: Andrew Harding <aharding@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.21 seems to use cgroups namespaces differently than 1.20. This breaks assumptions in the K8s workload attestor about how the paths of the cgroups are shaped which prevents the attestor from locating the
pod/container of the process under attestation.
This change relaxes the regular expression to not expect the cgroup paths we use to identify the pod/container to be expressely under a kubepods prefix.
Fixes: #2578