Validate upstream signed CA chain #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a validation step in the server CA before accepting an upstream signed intermediate which ensures that an SVID signed with that chain is valid. This prevents two kinds of misconfigurations: 1) the upstream authority did not return an intermediate chain that chains back to the upstream authority provided root, 2) the upstream authority produced a chain with invalid constraints (e.g. inappropriate key usage for certificate signing, missing CA bit, etc.) Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
rturner3
as code owners
3 tasks
MarcosDY
reviewed
Dec 6, 2021
Signed-off-by: Andrew Harding <aharding@vmware.com>
evan2645
previously approved these changes
Jan 4, 2022
Signed-off-by: Andrew Harding <aharding@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a validation step in the server CA before accepting an upstream signed intermediate which ensures that an SVID signed with that chain is valid. This prevents two kinds of misconfigurations: 1) the upstream authority did not return an intermediate chain that chains back to the upstream authority provided root, 2) the upstream authority produced a chain with invalid constraints (e.g. inappropriate key usage for certificate signing, missing CA bit, etc.)