Use API-level proto-to-id helper for audit fields #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few call sites were missed during the the recent change to introduce back-compat on "ensure leading slash" behavior where the audit fields are being populated. This could cause an API that was accepted to omit the SPIFFE ID or parent ID fields from the audit log. This change fixes those call sites to use the proper helpers from the API. The IDFromProto method is exported used instead of the more stringent TrustDomain*FromProto methods since audit logging doesn't need that extra validation. Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
requested review from
amartinezfayo,
evan2645 and
rturner3
as code owners
Closed
azdagron
deleted the
fix-audit-field-logging-for-paths-without-leading-slash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few call sites were missed during the the recent change to introduce back-compat on "ensure leading slash" behavior where the audit fields are being populated.
This could cause an API that was accepted to omit the SPIFFE ID or parent ID fields from the audit log.
This change fixes those call sites to use the proper helpers from the API. The IDFromProto method is exported used instead of the more stringent TrustDomain*FromProto methods since audit logging doesn't need that extra validation.