Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci also runs unit tests with -race enabled, but conditionally skips flaky tests #2705

Merged
merged 20 commits into from
Mar 15, 2022
Merged

ci also runs unit tests with -race enabled, but conditionally skips flaky tests #2705

merged 20 commits into from
Mar 15, 2022

Commits on Mar 10, 2022

  1. Instrument race-test target with SKIP_FLAKY_TESTS. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    9609818 View commit details
    Browse the repository at this point in the history

  2. Add make race-test to run_unit_tests.sh after make test. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    26498d8 View commit details
    Browse the repository at this point in the history

  3. Skip another flaky test and minor cleanup. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    d96cb0c View commit details
    Browse the repository at this point in the history

  4. Skip TestGenerateKey under race detector also. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    3859439 View commit details
    Browse the repository at this point in the history

  5. Add issue refs and clarify intent. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    d2babd6 View commit details
    Browse the repository at this point in the history

  6. fix lint 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    dd2553f View commit details
    Browse the repository at this point in the history

  7. Add GOVERBOSE to make race-test in run_unit_tests.sh. 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    c5e3d6c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. fix erroneous assert import 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    aa181de View commit details
    Browse the repository at this point in the history

  2. run unit-test-race-detector as separate workflow 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    f09a7ed View commit details
    Browse the repository at this point in the history

  3. make it fatal to skip without an issue 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    851c266 View commit details
    Browse the repository at this point in the history

  4. remove skips for fixed tests 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ecff992 View commit details
    Browse the repository at this point in the history

  5. skip TestManagerOnDemandBundleRefresh under race detector 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    bead7d0 View commit details
    Browse the repository at this point in the history

  6. fix typo in Makefile 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    200032c View commit details
    Browse the repository at this point in the history

  7. skip TestAttestAgent under race detector 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c66b5be View commit details
    Browse the repository at this point in the history

  8. do not run unit-test-race-detector on macos 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    a342226 View commit details
    Browse the repository at this point in the history

  9. clean up matrix since only linux for race detector 

    Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt
    zmt committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    9f2f1f6 View commit details
    Browse the repository at this point in the history

  10. Update .github/workflows/pr_build.yaml 

    Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Zack Train <ztrain@uber.com>
    @zmt @azdagron
    zmt and azdagron committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    9a2bf04 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Merge branch 'spiffe:main' into issue/2379

    @zmt
    zmt authored Mar 14, 2022
    Configuration menu
    Copy the full SHA
    2bad36b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'spiffe:main' into issue/2379

    @zmt
    zmt authored Mar 14, 2022
    Configuration menu
    Copy the full SHA
    872fa21 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Merge branch 'main' into issue/2379

    @azdagron
    azdagron authored Mar 15, 2022
    Configuration menu
    Copy the full SHA
    65beb52 View commit details
    Browse the repository at this point in the history