Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test to validate CRD mode #3219

Merged
merged 10 commits into from
Jul 8, 2022

Conversation

MarcosDY
Copy link
Collaborator

@MarcosDY MarcosDY commented Jul 5, 2022

Add integration test to validate CRD mode and validate that SVID contains DNS

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarcosDY for this!

@@ -0,0 +1,11 @@
# Kubernetes Suite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be updated with the tests specifically done in this suite?

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
@azdagron azdagron added this to the 1.4.0 milestone Jul 7, 2022
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarcosDY!

@amartinezfayo amartinezfayo merged commit 69aa102 into spiffe:main Jul 8, 2022
goergch pushed a commit to goergch/spire that referenced this pull request Jul 26, 2022
* Add integration test for CRD mode

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Christian Görg <christian.goerg@trumpf.com>
@MarcosDY MarcosDY deleted the add-crd-it branch February 17, 2023 17:18
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
* Add integration test for CRD mode

Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants