Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.4.0 #3234

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Bump version to 1.4.0 #3234

merged 1 commit into from
Jul 11, 2022

Conversation

azdagron
Copy link
Member

@azdagron azdagron commented Jul 8, 2022

Also pulled in CHANGELOG for 1.3.2 and updated upgrade IT.

Also pulled in CHANGELOG for 1.3.2 and updated upgrade IT

Signed-off-by: Andrew Harding <aharding@vmware.com>
@MarcosDY
Copy link
Collaborator

looks great, just a question...
may we add 1.4.0 to pkg\server\datastore\sqlstore\migration.go?

@azdagron
Copy link
Member Author

I could go either way. If we add it now, we might forget to update it if we add a migration before 1.4.0 is released. If we don't add it now, then it can be added later with the correct info 🤷

@azdagron
Copy link
Member Author

In the past we've usually updated that table with the latest release when we pull in the changelog into main.

Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@azdagron azdagron merged commit a9bae49 into spiffe:main Jul 11, 2022
@azdagron azdagron deleted the bump-version-1.4.0 branch July 11, 2022 16:04
@azdagron azdagron added this to the 1.4.0 milestone Jul 20, 2022
goergch pushed a commit to goergch/spire that referenced this pull request Jul 26, 2022
Also pulled in CHANGELOG for 1.3.2 and updated upgrade IT

Signed-off-by: Andrew Harding <aharding@vmware.com>
Signed-off-by: Christian Görg <christian.goerg@trumpf.com>
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
Also pulled in CHANGELOG for 1.3.2 and updated upgrade IT

Signed-off-by: Andrew Harding <aharding@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants