Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some spelling issues #3534

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Fix some spelling issues #3534

merged 5 commits into from
Oct 27, 2022

Conversation

keeganwitt
Copy link
Contributor

Just some spelling fixes and table reformatting.

@keeganwitt keeganwitt changed the title Fix spelling Fix some spelling issues Oct 26, 2022
azdagron
azdagron reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I saw just one additional thing that needed to be corrected. @MarcosDY , how is this going to play with #3494?

CHANGELOG.md Outdated Show resolved Hide resolved
@keeganwitt
Copy link
Contributor Author

Thanks! I saw just one additional thing that needed to be corrected. @MarcosDY , how is this going to play with #3494?

I know you weren't asking me, but FYI, the formatting I did here makes it match the formatting I previously did in #3474.
I don't see that the linting being worked on in #3494 has any table formatting.

@keeganwitt
Some spelling fixes
b5d878f 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt
Reformat some tables
2ec5446 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@keeganwitt
Fix spelling of "server"
106e24c 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
@azdagron azdagron added this to the 1.5.1 milestone Oct 27, 2022
azdagron
azdagron approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much, @keeganwitt !

@azdagron azdagron merged commit 1e400b1 into spiffe:main Oct 27, 2022
@keeganwitt keeganwitt deleted the fix_spelling branch October 27, 2022 20:40
stevend-uber pushed a commit to stevend-uber/spire that referenced this pull request Oct 16, 2023
@keeganwitt @stevend-uber
Fix some spelling issues (spiffe#3534)
4d08990 
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azdagron azdagron azdagron approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@amartinezfayo amartinezfayo Awaiting requested review from amartinezfayo amartinezfayo is a code owner

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@keeganwitt @azdagron