-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OIDC healthcheck to work with k8s healthprobes #3580
Conversation
1d8a9f1
to
2744990
Compare
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
2744990
to
73ff625
Compare
We don't typically do one-off patch releases for bug fixes unless it is a regression. In this instance, the health checks never worked on K8s to begin with. Are we overlooking a reason that this should be treated more urgently? In any case, I'll bring it up in today's contributor sync meeting. |
Only reason is that I want to enable the healthchecks again on the helm-chart. Since we moved to use the scratch images I can't use the old No hurry just trying to understand an approx timeframe. |
I see. 1.5.2 is currently scheduled to be released on Dec 14th. In the meantime, would it suffice to hit the existing HTTP endpoints (i.e. |
You can also test using the nightly images if that helps. |
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Pull Request check list
Affected functionality
oidc-provider healthcheck endpoint
Description of change
Allows the healthcheck to be called by ip address as well, so it works for kubernetes healthprobes.
Which issue this PR fixes
fixes #3572