Update agents listing service with "CanReAttest" filter #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermocc
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
|
I can review |
MarcosDY
reviewed
Mar 3, 2023
| @@ -266,7 +266,7 @@ func TestList(t *testing.T) { | |||
| expectedReturnCode: 0, | |||
There was a problem hiding this comment.
can you add a test case where an agent that is re_attestable is returned?
| @@ -289,6 +289,7 @@ StoreSvid : true | |||
| }, | |||
| "entry": { | |||
| "id": "entry-id", | |||
| "hint": "", | |||
There was a problem hiding this comment.
why hint is required here? looks like it is not related with this PR (the same comment is for all files with the same change)
There was a problem hiding this comment.
The new version of spire-api-sdk comes with the hint field change; that's why I had to include those here. This field will be effectively included in #3926
|
I recommend reviewing #3926 before this PR, since it will include the "hint" field which will also be added with the new spire-api-sdk version required by this PR. |
guilhermocc
force-pushed
the
update-agents-listing-service-with-new-filter
branch
from
59baf1f
to
659d2fc
Compare
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc
force-pushed
the
update-agents-listing-service-with-new-filter
branch
from
659d2fc
to
4b05585
Compare
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com>
guilhermocc
force-pushed
the
update-agents-listing-service-with-new-filter
branch
from
4bd9a7e
to
25f6a60
Compare
MarcosDY
approved these changes
Mar 9, 2023
moe-omar
pushed a commit
to moe-omar/spire
that referenced
this pull request
Jul 20, 2023
- Add "CanReAttest" boolean filter in list agents method - Update spire-server agent and entry commands to add new response fields: registration entry hint and agent canReAttest. --------- Signed-off-by: Guilherme Carvalho <guilhermbrsp@gmail.com> Signed-off-by: mo omar <momar@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
spire-server agents listing.
Description of change
agentandentrycommands to add new response fields: registration entryhintand agentcanReAttest.Which issue this PR fixes
Ongoing work for #1836
Dependencies
⚠️ This PR depends on spiffe/spire-api-sdk#36. After it's merge, go mod file should be updated to remove temporary local spire-api-sdk reference. ⚠️