New systemd workloadattestor plugin #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkaippully
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
rkaippully
changed the title
|
Thank you for contributing @rkaippully! |
guilhermocc
reviewed
Apr 10, 2023
pkg/agent/plugin/workloadattestor/systemd/systemd_posix_test.go
Outdated
Show resolved
Hide resolved
guilhermocc
reviewed
Apr 10, 2023
Fixes spiffe#2031. Adds a basic workloadattestor plugin to get systemd.unit properties of the running process. It uses dbus to find the unit corresponding to the process and exposes the `Id` and `FragmentPath` properties as selectors. Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
rkaippully
force-pushed
the
systemd-workloadattestor
branch
from
83364f9
to
61da87c
Compare
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
…ttestor Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
azdagron
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Excellent work @rkaippully ! Thank you for this contribution. I have just a few comments.
pkg/agent/plugin/workloadattestor/systemd/systemd_posix_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
azdagron
previously approved these changes
Apr 25, 2023
MarcosDY
reviewed
Apr 26, 2023
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
…ttestor Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
Signed-off-by: Raghu Kaippully <rkaippully@gmail.com>
maxlambrecht
approved these changes
May 4, 2023
|
@azdagron Thanks a lot for your review and approval. I see a test failure, but I don't think it has something to do with this change. Is that right? |
|
that test is flaky, I'm rerunning it |
d-goro
pushed a commit
to d-goro/spire
that referenced
this pull request
May 18, 2023
* systemd workloadattestor plugin Fixes spiffe#2031. Adds a basic workloadattestor plugin to get systemd.unit properties of the running process. Signed-off-by: Raghu Kaippully <rkaippully@gmail.com> Signed-off-by: Dmitry Gorochovsky <d.goro@yahoo.com>
Neniel
pushed a commit
to Neniel/spire
that referenced
this pull request
Aug 24, 2023
* systemd workloadattestor plugin Fixes spiffe#2031. Adds a basic workloadattestor plugin to get systemd.unit properties of the running process. Signed-off-by: Raghu Kaippully <rkaippully@gmail.com> Signed-off-by: Neniel <11655196+Neniel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
New workloadattestor plugin for systemd.
Description of change
Adds a basic workloadattestor plugin to get systemd.unit properties of the running process. It uses dbus to find the unit corresponding to the process and exposes the
IdandFragmentPathproperties as selectors.Which issue this PR fixes
Fixes #2031.