Add hint field delegated identity API #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermocc
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
guilhermocc
changed the title
guilhermocc
commented
Apr 13, 2023
guilhermocc
changed the title
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
guilhermocc
force-pushed
the
add-hint-field-delegated-identity-v1
branch
from
0881a7f
to
039fa18
Compare
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
MarcosDY
reviewed
Apr 14, 2023
| }, | ||
| jwtSVIDsResp: map[spiffeid.ID]*client.JWTSVID{ | ||
| id1: { | ||
| Token: jwtSVID1.Marshal(), |
There was a problem hiding this comment.
NIT: since you are using marshal for the very same token multiple times, what do you think about moving that into a variable? and just use vars here?
| Svids: []*types.JWTSVID{ | ||
| { | ||
| Token: jwtSVID1.Marshal(), | ||
| Id: &types.SPIFFEID{TrustDomain: id1.TrustDomain().String(), Path: id1.Path()}, |
There was a problem hiding this comment.
mmm, how about using api.ProtoFromID()?
Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me>
MarcosDY
approved these changes
Apr 17, 2023
Basavaraju-G
pushed a commit
to Basavaraju-G/spire
that referenced
this pull request
May 3, 2023
Add hint field delegated identity API Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> Signed-off-by: Basavaraju-G <basavaraju013@gmail.com>
d-goro
pushed a commit
to d-goro/spire
that referenced
this pull request
May 18, 2023
Add hint field delegated identity API Signed-off-by: Guilherme Carvalho <guilhermocc@proton.me> Signed-off-by: Dmitry Gorochovsky <d.goro@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Delegated API
FetchJWTSVIDsandSubscribeToX509SVIDsmethods.Description of change
Add hint field to delegated API responses
Which issue this PR fixes
Ongoing work for #2588
Dependencies
This PR depends on spiffe/spire-api-sdk#39; please review it first before merging this PR.