azure key vault plugin #4458
Merged
azure key vault plugin #4458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moe-omar
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
|
Thank you @moe-omar for this contribution! I've added a commit on top of the original contribution to:
|
3 tasks
MarcosDY
reviewed
Sep 1, 2023
| | Key | Type | Required | Description | Default | | ||
| |-------------------|---------|---------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------|---------| | ||
| | key_vault_uri | string | Yes | The Key Vault URI where the keys managed by this plugin reside. | "" | | ||
| | key_metadata_file | string | yes | A file path location where key metadata used by the plugin will be persisted. See "[Management of keys](#management-of-keys)" for more information. | "" | |
There was a problem hiding this comment.
can you keep the same order that in server_full.conf?
| } | ||
|
|
||
| // Skip keys that belong to this server | ||
| if p.serverID == *key.Tags[tagNameServerID] { |
There was a problem hiding this comment.
can you add more comments about why are we removing the keys that belongs to another server?
and no only taking care of own keys?
Signed-off-by: mo omar <momar@confluent.io>
- Change the implementation to create a new key when we need to generate a new one instead of adding a new version to an existing key. Once the key is created, the old one is deleted. Since key versions can't be deleted in Key Vault, this allows us to delete rotated keys. - Avoid disposing keys that belong to the current server. - Rename the plugin to azure_key_vault. - Fix tests and linter. Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
MarcosDY
force-pushed
the
azure-key-vault-plugin
branch
from
d3061e0
to
dec43bc
Compare
MarcosDY
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a server KMS plugin that uses Azure's Key Vault.
Pull Request check list
Affected functionality
No existing functionality affected. New server plugin added
Description of change
A new server keymanager plugin that uses Azure's Key Vault.
What/How was this new change tested?
rsa-2048,rsa-4096,ec-p256, andec-p384) for both JWT keys and CA keys.