-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/plugins/azure: use the default credentials API #4568
Conversation
@MarcosDY could you review this soon? This is blocking us from using SPIRE in Azure. |
2cac070
to
ace5f06
Compare
@shashankram can you resolve DCO? |
yes will address your comments and fix DCO |
7831de1
to
ec73dad
Compare
@MarcosDY Had to force-push to fix DCO, I addressed the comments |
Uses the NewDefaultAzureCredential API to fetch client credentials. This API wraps different mechanisms to obtain credentials using a chained token credential mechanism. By doing so, the Azure plugins are able to obtain a token using any of the supported mechanisms: env vars, MSI, workload identity, without needing separate config input for each. This is a part of spiffe#4485 to enable obtaining API tokens using Azure workload identity. Signed-off-by: Shashank Ram <shashr2204@gmail.com>
ec73dad
to
315a490
Compare
@shashankram code looks good, |
I'll push an update to this PR with the doc changes, thanks for the reminder! |
Signed-off-by: Shashank Ram <shashr2204@gmail.com>
@MarcosDY I updated the docs, let me know if it makes sense to you |
There seems to be a few unrelated test flakes. How do I rerun these? |
Uses the NewDefaultAzureCredential API to fetch client credentials. This API wraps different mechanisms to obtain credentials using a chained token credential mechanism. By doing so, the Azure plugins are able to obtain a token using any of the supported mechanisms: env vars, MSI, workload identity, without needing separate config input for each. Signed-off-by: Shashank Ram <shashr2204@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Uses the NewDefaultAzureCredential API to fetch
client credentials. This API wraps different
mechanisms to obtain credentials using a chained
token credential mechanism. By doing so, the Azure plugins are able to obtain a token using any of the supported mechanisms: env vars, MSI, workload identity, without needing separate config input for each.
This is a part of #4485 to enable obtaining API tokens using Azure workload identity.
Pull Request check list