Enable SPIRE Agent LRU cache by default #4773
Conversation
Signed-off-by: Prasad Borole <prasadb@uber.com>
prasadborole1
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
| @@ -468,6 +469,11 @@ func NewAgentConfig(c *Config, logOptions []log.Option, allowUnknownConfig bool) | |||
| ac.UseSyncAuthorizedEntries = c.Agent.Experimental.UseSyncAuthorizedEntries | |||
| ac.X509SVIDCacheMaxSize = c.Agent.Experimental.X509SVIDCacheMaxSize | |||
|
|
|||
| if c.Agent.Experimental.DisableLRUCache && ac.X509SVIDCacheMaxSize != 0 { | |||
There was a problem hiding this comment.
is it really experimental disablig LRU cache?
There was a problem hiding this comment.
may we add documentation about this configurable?
There was a problem hiding this comment.
Updated the README.
Signed-off-by: Prasad Borole <prasadb@uber.com>
doc/spire_agent.md
Outdated
| | `named_pipe_name` | Pipe name to bind the SPIRE Agent API named pipe (Windows only) | \spire-agent\public\api | | ||
| | `sync_interval` | Sync interval with SPIRE server with exponential backoff | 5 sec | | ||
| | `x509_svid_cache_max_size` | Soft limit of max number of SVIDs that would be stored in LRU cache | 1000 | | ||
| | `disable_lru_cache` | Disables the SPIRE Agent LRU cache used for storing SVIDs | false | |
There was a problem hiding this comment.
doc looks good, but I'm worried if people will understand what is the difference disabling it, can you explan a little more about how it will affect? maybe telling that it go back to old approach?
There was a problem hiding this comment.
Updated the description to convey that it will use non lru cache. cc @azdagron
|
@prasadborole1 any chance you can fix up the documentation as suggested by Marcos? Let us know if this is something you don't have time for and we'll get someone else to do it. Thanks! |
Signed-off-by: Prasad Borole <prasadb@uber.com>
* Enable SPIRE Agent LRU cache by default Signed-off-by: Prasad Borole <prasadb@uber.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
* Enable SPIRE Agent LRU cache by default Signed-off-by: Prasad Borole <prasadb@uber.com>
* Enable SPIRE Agent LRU cache by default Signed-off-by: Prasad Borole <prasadb@uber.com>
x509_svid_cache_max_size.disable_lru_cacheto allow fallback to original cache.Addresses #4224