-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow Ubuntu to 22.04 #4882
Conversation
The changes to MAXCHECKS seem unnecessary? MAXCHECKS should be evaluating to the proper value in those bash arithmetic expressions without the $. Are you seeing differently? |
No it's not necessary. I was trying a few different things to see what's causing the failure. |
Looks like when you upgraded ubuntu to 22.04, docker start to use cgroupv2, that cause that |
I'm working on #4004 this week. |
@faisal-memon can you remove unnecessary changes (changes related with testing why it was failing) and resolve DCO? |
Integration tests are now passing, @faisal-memon. Feel free to just squash my commits in with your other edits when you fix DCO. |
Backed out all the unnecessary changes |
Thanks @faisal-memon. I think you need to re-introduce one change (shellcheck is complaining during linting). Afterwards feel free to squash the changes, fix up DCO, and force-push. I'll re-review the final change and then we can get this merged! |
122c750
to
36519fb
Compare
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
36519fb
to
d3b2a86
Compare
@azdagron Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @faisal-memon!
Pull Request check list
Affected functionality
Various github actions
Description of change
Updates ubuntu versions in all workflows to 22.04
Which issue this PR fixes
N/A