Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow Ubuntu to 22.04 #4882

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

faisal-memon
Copy link
Contributor

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality
Various github actions

Description of change
Updates ubuntu versions in all workflows to 22.04

Which issue this PR fixes
N/A

@azdagron
Copy link
Member

The changes to MAXCHECKS seem unnecessary? MAXCHECKS should be evaluating to the proper value in those bash arithmetic expressions without the $. Are you seeing differently?

@faisal-memon
Copy link
Contributor Author

The changes to MAXCHECKS seem unnecessary? MAXCHECKS should be evaluating to the proper value in those bash arithmetic expressions without the $. Are you seeing differently?

No it's not necessary. I was trying a few different things to see what's causing the failure.

@MarcosDY
Copy link
Collaborator

MarcosDY commented Mar 4, 2024

Looks like when you upgraded ubuntu to 22.04, docker start to use cgroupv2, that cause that /proc/${PID}/cgroup is containing only 0::/, so spire is unable to get container ID,
in order to have a success upgrade we must address #4004

@azdagron
Copy link
Member

azdagron commented Mar 4, 2024

I'm working on #4004 this week.

@MarcosDY
Copy link
Collaborator

@faisal-memon can you remove unnecessary changes (changes related with testing why it was failing) and resolve DCO?

@azdagron
Copy link
Member

azdagron commented May 8, 2024

Integration tests are now passing, @faisal-memon. Feel free to just squash my commits in with your other edits when you fix DCO.

@faisal-memon
Copy link
Contributor Author

Backed out all the unnecessary changes

@azdagron
Copy link
Member

Thanks @faisal-memon. I think you need to re-introduce one change (shellcheck is complaining during linting). Afterwards feel free to squash the changes, fix up DCO, and force-push. I'll re-review the final change and then we can get this merged!

Signed-off-by: Faisal Memon <fymemon@yahoo.com>
@faisal-memon faisal-memon changed the title Update workflow ubuntu to 22.04 Update workflow Ubuntu to 22.04 May 16, 2024
@faisal-memon
Copy link
Contributor Author

Thanks @faisal-memon. I think you need to re-introduce one change (shellcheck is complaining during linting). Afterwards feel free to squash the changes, fix up DCO, and force-push. I'll re-review the final change and then we can get this merged!

@azdagron Should be good to go now.

Copy link
Member

@azdagron azdagron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @faisal-memon!

@azdagron azdagron merged commit 1c6e144 into spiffe:main May 17, 2024
33 checks passed
@faisal-memon faisal-memon deleted the update-ubuntu-22 branch May 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants