Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce aws_rolesanywhere_trustanchor BundlePublisher plugin #5048

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Introduce aws_rolesanywhere_trustanchor BundlePublisher plugin #5048

merged 5 commits into from
Jul 1, 2024

Commits on Jul 1, 2024

  1. Introduce the aws_rolesanywhere_trustanchor BundlePublisher plugin 

    * Implement and add tests for the plugin

Signed-off-by: Ajay Gupta <apg76@cornell.edu>
    @ajay1135
    ajay1135 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    11f14d1 View commit details
    Browse the repository at this point in the history

  2. Add documentation for aws_rolesanywhere_trustanchor BundlePublisher p… 

    …lugin

Signed-off-by: Ajay Gupta <apg76@cornell.edu>
    @ajay1135
    ajay1135 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    99e18b0 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: ajay1135 <32616412+ajay1135@users.noreply.github.com>
    @ajay1135 @amartinezfayo
    ajay1135 and amartinezfayo committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    82c6064 View commit details
    Browse the repository at this point in the history

  4. Address comments on PR 

    * Only required rolesanywhere:UpdateTrustAnchor permissions (no creating
  or listing)
* Add note about how this plugin is only supported when an
  UpstreamAuthority plugin is also used
* Use ID instead of trust anchor name to identify trust anchors, as it's
  unique
* Check that certificate bundles don't exceed a length of 8000 before
  making the UpdateTrustAnchor API call
* Make corresponding changes to unit tests

Signed-off-by: Ajay Gupta <apg76@cornell.edu>
    @ajay1135
    ajay1135 committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7a512c1 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: ajay1135 <32616412+ajay1135@users.noreply.github.com>
    @ajay1135 @amartinezfayo
    ajay1135 and amartinezfayo committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    153943b View commit details
    Browse the repository at this point in the history