Events based cache: Address missed code review comments #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
faisal-memon
commented
Jun 24, 2024
Comment on lines
+160
to
+168
| // If there is a gap in the event stream, log the missed events for later processing. | ||
| // For example if the current event ID is 6 and the previous one was 3, events 4 and 5 | ||
| // were skipped over and need to be queued in case they show up later. | ||
| // This can happen when a long running transaction allocates an event ID but a shorter transaction | ||
| // comes in after, allocates and commits the ID first. If a read comes in at this moment, the event id for | ||
| // the longer running transaction will be skipped over | ||
| if a.receivedFirstRegistrationEntryEvent && event.EventID != a.lastRegistrationEntryEventID+1 { | ||
| for i := a.lastRegistrationEntryEventID + 1; i < event.EventID; i++ { | ||
| a.log.WithField(telemetry.EventID, i).Info("Detected skipped registration entry event") |
There was a problem hiding this comment.
Addresses this comment: #5071 (comment)
faisal-memon
commented
Jun 24, 2024
Comment on lines
-249
to
+268
| // If there is a gap in the event stream, log the missed events for later processing | ||
| // If there is a gap in the event stream, log the missed events for later processing. | ||
| // For example if the current event ID is 6 and the previous one was 3, events 4 and 5 | ||
| // were skipped over and need to be queued in case they show up later. | ||
| // This can happen when a long running transaction allocates an event ID but a shorter transaction | ||
| // comes in after, allocates and commits the ID first. If a read comes in at this moment, the event id for | ||
| // the longer running transaction will be skipped over | ||
| if a.receivedFirstAttestedNodeEvent && event.EventID != a.lastRegistrationEntryEventID+1 { | ||
| for i := a.lastAttestedNodeEventID + 1; i < event.EventID; i++ { | ||
| a.log.WithField(telemetry.EventID, i).Info("Detected skipped attested node event") |
There was a problem hiding this comment.
Addresses this comment: #5071 (comment)
faisal-memon
commented
Jun 24, 2024
Comment on lines
229
to
237
| if commonEntry == nil { | ||
| a.cache.RemoveEntry(entryID) | ||
| return nil | ||
| } | ||
|
|
||
| entry, err := api.RegistrationEntryToProto(commonEntry) | ||
| if err != nil { | ||
| a.cache.RemoveEntry(entryID) | ||
| return nil | ||
| return fmt.Errorf("removing malformed entry %s from cache: %w", entryID, err) |
There was a problem hiding this comment.
Addresses this comment: #5071 (comment)
There was a problem hiding this comment.
Won't returning an error here result in the event being processed again (and again and again), presumably with the same outcome each time (assuming the entry is malformed)?
IMO, this condition should be logged but otherwise the event should be considered handled.
There was a problem hiding this comment.
Good catch, fixed.
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
azdagron
reviewed
Jun 25, 2024
| entry, err := api.RegistrationEntryToProto(commonEntry) | ||
| if err != nil { | ||
| a.cache.RemoveEntry(entryID) | ||
| a.log.WithField(telemetry.RegistrationID, entryID).Info("Removed malformed registration entry from cache") |
There was a problem hiding this comment.
This is problematic enough we should log it at Warn level
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
azdagron
approved these changes
Jun 25, 2024
edwbuck
pushed a commit
to edwbuck/spire
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Events based cache
Description of change
Addressing some comments missed in review of #5071. It was merged before i could address them.
Which issue this PR fixes