server CA persistence support #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates memory CA to optionally persist signing keypair to disk. - updates CA manager to skip the initial rotation if there is a good keypair returned by the CA. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
ajessup,
amartinezfayo,
drrt,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
walmav
reviewed
Jul 12, 2018
| if the server is restarted, a new signing authority is generated against the upstream CA. | ||
| The `memory` plugin implements an in-memory signing authority. The signing | ||
| keypair is optionally persisted to disk. When the server is loaded, if no | ||
| keypair has been persisted, or if the keypair is expiring/expired, a new |
There was a problem hiding this comment.
Same way it is done today. Certificate is "expiring" when it is within 1/6th of the ttl left.
evan2645
approved these changes
Jul 12, 2018
| @@ -1,13 +1,15 @@ | |||
| # Server plugin: ServerCA "memory" | |||
There was a problem hiding this comment.
Is the name memory still accurate if the plugin can also persist to disk?
For now I think this is fine, but after upcoming ServerCA refactors we may want to consider making the disk-based functionality a dedicated plugin
walmav
approved these changes
Jul 12, 2018
|
⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keypair returned by the CA.
Signed-off-by: Andrew Harding azdagron@gmail.com