SVID count update #5352
Merged
SVID count update #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FedeNQ <fedenahuel07@gmail.com>
FedeNQ
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
| @@ -250,6 +250,10 @@ func (c *Cache) GetStaleEntries() []*cache.StaleEntry { | |||
| return staleEntries | |||
| } | |||
|
|
|||
| func (c *Cache) CountX509SVIDs() int { | |||
| return len(c.records) | |||
There was a problem hiding this comment.
We should lock the mutex for reading to get the length of the records.
Suggested change
| return len(c.records) | |
| c.mtx.RLock() | |
| defer c.mtx.RUnlock() | |
| return len(c.records) |
| // CountJWTSVIDs returns the amount of JWT SVIDs on memory | ||
| CountJWTSVIDs() int | ||
|
|
||
| CountSVIDStoreX509SVIDs() int |
There was a problem hiding this comment.
nit: Add a descriptive comment here as we have for the other counts.
Signed-off-by: FedeNQ <fedenahuel07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Description of change
Add 3 new variables replacing svids_count, that will be deprecated.
Variables added:
Which issue this PR fixes
fixes #3256