Return InvalidArgument for invalid input entries #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
commented
Sep 20, 2024
| @@ -658,6 +755,13 @@ func (s *Service) updateEntry(ctx context.Context, e *types.Entry, inputMask *ty | |||
| Hint: inputMask.Hint, | |||
| } | |||
| } | |||
|
|
|||
| if err := validateRegistrationEntryForUpdate(convEntry, mask); err != nil { | |||
There was a problem hiding this comment.
An alternative to this would be to add all the validations here in
Line 92 in 3d158ce
That function already does some validations, but mostly as a necessity of handling errors. It would also simplify things a bit. Let me know if that's better and I can change this.
sorindumitru
force-pushed
the
entry-errors
branch
2 times, most recently
from
59afb34
to
a88df74
Compare
Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
entry-errors
branch
from
a88df74
to
4a907bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected functionality
Returned error codes for BatchCreateEntry/BatchUpdateEntry
Description of change
Return better error codes in case of invalid entries so users can differentiate between entries that can be retried and those that can't
Which issue this PR fixes
fixes #5444