Merge AWS node resolver #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS Node Resolver
build infra
make aws creds config optional
Fixed DescribeRegions call failing. Fixed returning duplicate selectors.
Added goreleaser
Signed-off-by: Andrew Harding <azdagron@gmail.com>
- removed the standalone hashicorp plugin scaffolding - fixed some vet issues and brought the code back in line with the noderesolver interface - removed standalone project scaffolding (makefile, license, etc.) - dropped the tests, which have rotted a bit and have incomplete mock scaffolding (e.g. require real AWS creds and hit real APIs) Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit merges the AWS node resolver plugin from github.com/spiffe/aws-resolver.
It also prepares the code to live in the spire codebase as a built-in plugin by:
A follow-up PR will contain some code cleanup and reintroduce tests that don't hit AWS APIs.