Spelling and grammar fixes #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganwitt
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
keeganwitt
force-pushed
the
spelling-and-grammar-fixes
branch
from
5630999
to
c24ec51
Compare
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
keeganwitt
force-pushed
the
spelling-and-grammar-fixes
branch
from
818cab3
to
cb640dd
Compare
azdagron
reviewed
Oct 17, 2024
| @@ -185,7 +185,7 @@ func TestGcpCAS(t *testing.T) { | |||
| } | |||
|
|
|||
| func generateCert(t *testing.T, cn string, issuer *x509.Certificate, issuerKey crypto.PrivateKey, ttlInHours int, keyfn func(testing.TB) *ecdsa.PrivateKey) (*x509.Certificate, crypto.PrivateKey, error) { | |||
| priv := keyfn(t) | |||
| keyPair := keyfn(t) | |||
There was a problem hiding this comment.
I thought that looked confusing for line 208, it'd be
privateKey.Public()instead of
keyPair.Public()
|
Friendly ping @keeganwitt :) As soon as the comments are addressed I think we're good to merge. |
Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
Co-authored-by: Andrew Harding <azdagron@gmail.com> Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
…r-fixes Signed-off-by: Keegan Witt <keeganwitt@gmail.com> # Conflicts: # pkg/common/fflag/fflag.go # pkg/server/endpoints/authorized_entryfetcher_attested_nodes.go # pkg/server/endpoints/authorized_entryfetcher_attested_nodes_test.go # pkg/server/endpoints/authorized_entryfetcher_registration_entries.go # pkg/server/endpoints/authorized_entryfetcher_registration_entries_test.go
azdagron
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of spelling, grammar, and Markdown table formatting problems.