Enable optional trust domain label for all metrics #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceajibade
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
graceajibade
force-pushed
the
gracepatch
branch
2 times, most recently
from
7d27be8 to
0ce122b
Compare
graceajibade
force-pushed
the
gracepatch
branch
from
e2302d1 to
5938f07
Compare
MarcosDY
reviewed
Dec 17, 2024
graceajibade
force-pushed
the
gracepatch
branch
from
fe3f092 to
b06fee1
Compare
|
Just mentioning here that this addresses issue #5652. |
|
@graceajibade can you resolve DCO? |
graceajibade
force-pushed
the
gracepatch
branch
5 times, most recently
from
ff8700f to
be630c0
Compare
added 4 commits
January 3, 2025 15:16
Signed-off-by: gajibade <gajibade@bloomberg.net>
Signed-off-by: gajibade <gajibade@bloomberg.net>
graceajibade
force-pushed
the
gracepatch
branch
from
be630c0 to
678bead
Compare
MarcosDY
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on this comment and the desire for a different tag name than
servicewhich is what go-metrics would use as a label ifServiceNameandEnableServiceLabelwere used.The
trust_domainlabel was used to separate it from thetrust_domain_idlabel that is already added for some metrics.Since this label is enabled for all metrics, the best place to add it looks to be in each of the metric function in metric.go.
Fixes #5652