agent: accept registration entries with RevisionNumber 0 #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
sorindumitru
changed the title
When using the SyncAuthorizedEntries API we verify that the RevisionNumber of the entries is at least 1. Unfortunately, the RevisionNumber as assigned by spire-server starts at 0, leading to the following error: ``` WARN[0004] Received malformed entry revision from SPIRE server; are the server and agent versions compatible? entry_id=f1a26ecf-1043-4905-b5d9-789e60f88695 revision_number=0 subsystem_name=manager ```` I'm guessing the check is there in the unlikely case of a wrap-around, so I'm keeping it and verifying that the RevisionNumber is positive. Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sorindumitru
force-pushed
the
sync-authorized-entries-revision-number
branch
from
0404c75 to
ce63fcc
Compare
amartinezfayo
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the SyncAuthorizedEntries API we verify that the RevisionNumber of the entries is at least 1. Unfortunately, the RevisionNumber as assigned by spire-server starts at 0, leading to the following error:
I'm guessing the check is there in the unlikely case of a wrap-around, so I'm keeping it and verifying that the RevisionNumber is positive.
No tests here, but I'm working on adding some general tests for the feature in a follow-up PR.