Add mode flag to bundle deletion #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundles cannot be deleted from the datastore if they are associated with any registration entries unless the dissociate or delete mode is used. This commit adds mode to the registration API and plumbs it through to the CLI. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
ajessup,
amartinezfayo,
drrt,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
azdagron
changed the title
| @@ -34,6 +44,7 @@ func (c *deleteCommand) synopsis() string { | |||
|
|
|||
| func (c *deleteCommand) appendFlags(fs *flag.FlagSet) { | |||
| fs.StringVar(&c.id, "id", "", "SPIFFE ID of the trust domain") | |||
| fs.StringVar(&c.mode, "mode", deleteBundleRestrict, "Deletion mode: one of restrict, delete, or dissociate") | |||
There was a problem hiding this comment.
Maybe it make sense to use the constants also to build the usage string?
There was a problem hiding this comment.
sure, why not! commit coming up.
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles cannot be deleted from the datastore if they are associated with
any registration entries unless the dissociate or delete mode is used.
This commit adds mode to the registration API and plumbs it through to
the CLI.