Store CA intermediates in bundle #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIRE was recently refactored to properly convey signing intermediates down through the Node and Workload APIs. At that time the bundle was changed to only include the signing root. Backwards compatability with old agents was done at the Node API layer; intermediate certificates from minted SVIDs were appended to the bundle before the result was returned to the agent. This approach was insufficient and broken since 1) the intermediates would not be appended to bundles returned to agents talking with other servers (in an HA scenario), and 2) the agent uses the same fetch call to learn about new registration entries without asking for anything to be signed, which caused the server to return a bundle without intermediates. This change removes the shim in the Node API and instead stores the intermediates in the bundle so they are consistently returned from the Node API and available in HA depoloyments. SPIRE 0.8.0 can revert the change to no longer store the intermediates. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRE was recently refactored to properly convey signing intermediates
down through the Node and Workload APIs. At that time the bundle was
changed to only include the signing root. Backwards compatability with
old agents was done at the Node API layer; intermediate certificates
from minted SVIDs were appended to the bundle before the result was
returned to the agent.
This approach was insufficient and broken since 1) the intermediates
would not be appended to bundles returned to agents talking with other
servers (in an HA scenario), and 2) the agent uses the same fetch call
to learn about new registration entries without asking for anything to
be signed, which caused the server to return a bundle without
intermediates.
This change removes the shim in the Node API and instead stores the
intermediates in the bundle so they are consistently returned from the
Node API and available in HA depoloyments. SPIRE 0.8.0 can revert the
change to no longer store the intermediates.