Fix debug message formatting in node resolver #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotte
requested review from
amartinezfayo,
azdagron,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
azdagron
previously approved these changes
Jan 8, 2019
pkg/server/endpoints/node/handler.go
Outdated
| @@ -512,7 +512,7 @@ func (h *Handler) updateNodeSelectors(ctx context.Context, | |||
| var selectors []*common.Selector | |||
| if nodeResolver == nil { | |||
| // If not matching node resolver found, skip adding additional selectors | |||
| h.c.Log.Debug("could not find node resolver type %q", attestationType) | |||
| h.c.Log.Debugf("could not find node resolver type %v", attestationType) | |||
There was a problem hiding this comment.
nit: Can we keep the ÷q format specifier? It adds quotes around the attestor type that helps provide visual distinction.
There was a problem hiding this comment.
Sorry, fixed in the amended commit...
Signed-off-by: Scott Emmons <scott@scytale.io>
scotte
force-pushed
the
fix_node_resolver_debug
branch
from
cf4760a to
aff7261
Compare
azdagron
approved these changes
Jan 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Emmons scott@scytale.io
This should fix node resolver debug log messages that look like: