Fix panic in signCSRs if no attested node record found #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
azdagron
changed the title
azdagron
force-pushed
the
fix-sign-csr-panic
branch
3 times, most recently
from
0bb39e9 to
a196f01
Compare
Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
force-pushed
the
fix-sign-csr-panic
branch
from
a196f01 to
14912fc
Compare
evan2645
approved these changes
Jan 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a check that there is an attested node entry before trying to use it while exercising signCSR to sign a a Node SVID.
Fixes #682