Persist Tornjak DB info #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
maia-iyer
approved these changes
Mar 23, 2023
| s.Db, err = agentdb.NewLocalSqliteDB("sqlite3", "./localtornjakdb", expBackoff) | ||
| s.Db, err = agentdb.NewLocalSqliteDB("sqlite3", "./tornjak.sqlite3", expBackoff) |
There was a problem hiding this comment.
I think this should end up being the run/spire/data/tornjak.sqlite3
to make sure it is in the right persistent volume. Currently this is not testable because we made the DB a required configuration.
Otherwise, the default value can be up to discussion - but given all our quickstarts have the same structure, we can have the default be placing it in the right volume for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tornjak DB has to be moved to the persistent storage, e.g. same place where the SPIRE DB is kept.
Move the Tornjak DB to persistent storage and update the file name to be more descriptive.
This PR resolves issue #137