Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding path module and a fallback - frontend #187

Merged
merged 1 commit into from
May 2, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented May 2, 2023

Solves:
Module not found: Error: Can't resolve 'path' in '/home/runner/work/tornjak/tornjak/tornjak-frontend/node_modules/dotenv/lib' 478
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. 479
This is no longer the case. Verify if you need this module and configure a polyfill for it. 480
If you want to include a polyfill, you need to: 482
- add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }' 483
- install 'path-browserify' 484
If you don't want to include a polyfill, you can use an empty module like this: 485
resolve.fallback: { "path": false } 486
make: *** [Makefile:43: ui-manager] Error 1

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
@mamy-CS mamy-CS added this to the 1.2.x milestone May 2, 2023
@mamy-CS mamy-CS requested a review from lumjjb as a code owner May 2, 2023 16:57
@mamy-CS mamy-CS self-assigned this May 2, 2023
@mamy-CS mamy-CS requested a review from mrsabath as a code owner May 2, 2023 16:57
@mrsabath mrsabath merged commit aa1c5f4 into spiffe:v1.2.0 May 2, 2023
mamy-CS added a commit to mamy-CS/tornjak-public that referenced this pull request May 3, 2023
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
mrsabath pushed a commit that referenced this pull request May 3, 2023
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
mrsabath pushed a commit that referenced this pull request May 3, 2023
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants