Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra calls to authorization #225

Merged
merged 1 commit into from
May 23, 2023
Merged

Add extra calls to authorization #225

merged 1 commit into from
May 23, 2023

Conversation

maia-iyer
Copy link
Collaborator

Recently for v1.2, we added backend calls:

  • /api/healthcheck
  • /api/debugserver

Adding these to default auth Keycloak plugin as viewer-level for now.
Also added / path as needing no auth token

Future intention of splitting these authentication/authorization logics.

Closes #157

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer requested review from lumjjb and mrsabath as code owners May 23, 2023 14:57
@mamy-CS mamy-CS added this to the 1.2.x milestone May 23, 2023
@mamy-CS mamy-CS changed the title Added extra calls to authorization Adding extra calls to authorization May 23, 2023
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maia-iyer maia-iyer merged commit 1f97215 into v1.2 May 23, 2023
maia-iyer added a commit that referenced this pull request Jun 1, 2023
* Removing backend + spire implementations

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Commented on Makefile and adjusted names

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Update .github/workflows/master-build.yaml

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* rename variables

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* remove latest tag

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* New version v1.2.2

Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>

* Makefile nit Github (#224)

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Fixing Dockerfiles (#227)

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Added extra calls to authorization (#225)

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* adding local name

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* fixing build

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* additional commenting and renaming of local frontend build

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* adjust documentation

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* re-deleting files

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Makefile edits

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Comments

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Replacing DEV tag

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* nits

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Refactoring repo naming

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* adding dev-sha target

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Fix 'access denied' error when running in restricted (read-only) env

Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>

* removing duplicate make targets

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* removing nit comment

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Update Makefile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>

* Fix 'access denied' error when running in restricted (read-only) env

Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>

* Fix startup error

Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>

* Remove unneeded backend+SPIRE dockerfile

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Adding comment

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

---------

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Co-authored-by: Maia Iyer <maia.raj.iyer@gmail.com>
@mrsabath mrsabath changed the title Adding extra calls to authorization Add extra calls to authorization Jun 8, 2023
@maia-iyer maia-iyer deleted the auth_policy_extension branch August 1, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify <tornjak-backend-api>/~ command to not require authorization
3 participants