Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'access denied' error when running in restricted (read-only) env #233

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix 'access denied' error when running in restricted (read-only) env #233

merged 2 commits into from
May 31, 2023

Conversation

mrsabath
Copy link
Collaborator

When container image deployed in read-only environment (e.g. restricted namespace), write-access is required for outputting "env.js" file. Redirecting output of this file to "/tmp" directory

@mrsabath
Fix 'access denied' error when running in restricted (read-only) env
9940dd4 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath marked this pull request as ready for review May 26, 2023 19:38
@mrsabath mrsabath requested a review from lumjjb as a code owner May 26, 2023 19:38
@mrsabath mrsabath requested review from mamy-CS and removed request for lumjjb May 26, 2023 19:38
@mrsabath mrsabath mentioned this pull request May 30, 2023
Open
mamy-CS
mamy-CS requested changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 36-38 is duplicate, please remove other than that lgtm!
RUN npm install --omit=dev \ npm prune --production ENTRYPOINT npx react-inject-env set && serve -s build -p $PORT_FE

@mrsabath
Fix 'access denied' error when running in restricted (read-only) env
f9eebe3 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
mamy-CS
mamy-CS approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mrsabath mrsabath merged commit 533c26b into v1.2 May 31, 2023
@mrsabath
Copy link
Collaborator Author

mrsabath commented Jun 8, 2023

This PR is fixing the issue #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamy-CS mamy-CS mamy-CS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsabath @mamy-CS