Delete cluster in cluster edit [Cluster management ** HOLD**] #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb
reviewed
Aug 27, 2021
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb
previously approved these changes
Aug 30, 2021
lumjjb
reviewed
Aug 30, 2021
| } else { | ||
| this.TornjakApi.localClusterDelete(inputData, this.props.clustersListUpdateFunc, this.props.globalClustersList); | ||
| } | ||
| window.alert("CLUSTER DELETED SUCCESSFULLY!"); |
There was a problem hiding this comment.
how do you know deletion is successful? How do you know if its successfully run?
lumjjb
reviewed
Aug 30, 2021
| this.TornjakApi.localClusterDelete(inputData, this.props.clustersListUpdateFunc, this.props.globalClustersList); | ||
| } | ||
| window.alert("CLUSTER DELETED SUCCESSFULLY!"); | ||
| window.location.reload(); |
There was a problem hiding this comment.
What happens here if it reloads and the async function is still running?
added 2 commits
August 30, 2021 11:46
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
|
Waiting on TypeScript completion |
lumjjb
reviewed
Jan 25, 2022
mrsabath
changed the title
|
Rebased and moved to #333 to finish. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
Signed-off-by: Mohammed Abdi mohammed.munir.abdi@ibm.com