Document Makefile and align .PHONY with available tasks #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
requested review from
lumjjb,
mrsabath,
mamy-CS and
maia-iyer
as code owners
marcofranssen
force-pushed
the
optimize-makefile
branch
from
0ccb8b7 to
8258c08
Compare
marcofranssen
commented
Jun 27, 2023
| @@ -1,5 +1,3 @@ | |||
| .PHONY: ui vendor build container-manager container-manager-push push container-frontend container-frontend-push container-backend container-backend-push | |||
There was a problem hiding this comment.
ui build push targets didn't exist anymore, moved the existing ones with the respective target to make it easier to keep these in sync (more easy to detect during a review).
marcofranssen
force-pushed
the
optimize-makefile
branch
6 times, most recently
from
58a491e to
62a10d2
Compare
marcofranssen
force-pushed
the
optimize-makefile
branch
from
62a10d2 to
1bba0f8
Compare
marcofranssen
changed the title
marcofranssen
force-pushed
the
optimize-makefile
branch
5 times, most recently
from
8999b96 to
28575ec
Compare
This takes the latest patch release of similar to our previous version, except now we don't have the Go version duplicated in 3 places Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
This caches based on the checksums Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
optimize-makefile
branch
from
28575ec to
e7f4239
Compare
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
optimize-makefile
branch
4 times, most recently
from
9851276 to
6f7d39a
Compare
marcofranssen
force-pushed
the
optimize-makefile
branch
from
6f7d39a to
f5c764a
Compare
Some old .PHONY targets where there where the target itself wasn't there anymore. By defining the PHONY with the target it is easier to keep this in sync in the future Also added a help target that prints a nicely formatted help for every single make target. Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Splitting into separate workflow steps makes the workflow more transparant Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
optimize-makefile
branch
from
f5c764a to
205dbd7
Compare
mrsabath
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
This is a really nice update @marcofranssen Thank you!
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old .PHONY targets where there where the target itself wasn't there anymore. By defining the PHONY with the target it is easier to keep this in sync in the future
Also added a help target that prints a nicely formatted help for every single make target.