Implement HTTP/HTTPS including permanent redirect #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
force-pushed
the
refactor-http-https
branch
5 times, most recently
from
d24f558 to
9b5a391
Compare
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
refactor-http-https
branch
from
9b5a391 to
12b1590
Compare
marcofranssen
requested review from
lumjjb,
mrsabath,
mamy-CS and
maia-iyer
as code owners
marcofranssen
commented
Jun 30, 2023
| // TLS Stack handling | ||
| numPorts := 0 // TODO: replace with workerGroup for thread safety | ||
| errChannel := make(chan error, 2) | ||
| var httpHandler http.Handler = http.HandlerFunc(redirectHTTP) |
There was a problem hiding this comment.
Permanent redirect to HTTPS.
marcofranssen
commented
Jun 30, 2023
| // log.Printf("HTTP serve error: %v", err) | ||
| }() | ||
| if serverConfig.HTTPSConfig == nil { | ||
| httpHandler = s.GetRouter() |
There was a problem hiding this comment.
If no https configured, then just let http handle the api requests.
mrsabath
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #268
Builds on top of #281, so merge that one first to get a cleaner diff here.
Haven't tested it, because I can't get the docker compile to run on my local. I freezes my entire docker engine till it crashes.