Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build artifacts CI #31

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Add build artifacts CI #31

merged 2 commits into from
Sep 14, 2021

Conversation

lumjjb
Copy link
Collaborator

@lumjjb lumjjb commented Sep 10, 2021

Test out the ability to push to Github Container Registry on master commits

Signed-off-by: Brandon Lum lumjjb@gmail.com

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb self-assigned this Sep 10, 2021
Comment on lines +27 to +32
- name: Log in to GHCR.io
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan2645 this works perfectly, if we want to move our images to ghcr.io.

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumjjb lumjjb merged commit a334cde into main Sep 14, 2021
mrsabath pushed a commit to mrsabath/tornjak-1 that referenced this pull request Sep 15, 2021
* Add build artifacts CI

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* Reorder spire versions build

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants