Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify JWKS URL in config to Issuer URL for OIDC Discovery in Backend (#370) #393

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

maia-iyer
Copy link
Collaborator

Instead of passing JWKS URL to backend, we pass Issuer URL

closes #370

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added IAM backend Tornjak API (Backend) labels Apr 2, 2024
@maia-iyer maia-iyer added this to the 1.6.x milestone Apr 2, 2024
@maia-iyer maia-iyer self-assigned this Apr 2, 2024
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Tested locally and everything looks good. Let's create an issue for handling the error when IAM is not up to make it more clear. Other than that approving. Thanks.

@maia-iyer maia-iyer merged commit f762363 into v1.6 Apr 4, 2024
8 checks passed
@maia-iyer maia-iyer deleted the add_oidc_discovery branch November 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) IAM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make backend use OIDC Discovery for jwks URL
2 participants