Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mTLS CA Option on tornjak server #43

Merged
merged 7 commits into from
Mar 1, 2022
Merged

Add mTLS CA Option on tornjak server #43

merged 7 commits into from
Mar 1, 2022

Conversation

lumjjb
Copy link
Collaborator

@lumjjb lumjjb commented Nov 19, 2021 •
edited
Loading

Addresses #2, by providing a —mtls-ca flag to validate mTLS certificates for validation of client certs.

Signed-off-by: Brandon Lum lumjjb@gmail.com

@lumjjb lumjjb requested a review from mrsabath as a code owner November 19, 2021 16:14
@lumjjb lumjjb force-pushed the add-agent-tls-ca-opt branch from 6e8c369 to 16f8c8c Compare November 19, 2021 16:16
@mrsabath
Copy link
Collaborator

mrsabath commented Jan 11, 2022 •
edited
Loading

Check with @lumjjb if ready to merge

@mrsabath mrsabath self-assigned this Feb 2, 2022
@mrsabath
Copy link
Collaborator

mrsabath commented Feb 2, 2022

Testing and documentation (explain the server params, key management)

lumjjb and others added 3 commits February 14, 2022 13:53
@lumjjb @mrsabath
Add mTLS CA Option on tornjak server
b68cd5e 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb @mrsabath
add mtls-ca flag to run_server.sh
641d3e0 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@mrsabath
Updated documenation and Tornjak Manager debug
9116f87 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath force-pushed the add-agent-tls-ca-opt branch from d20e7fa to 9116f87 Compare February 17, 2022 02:43
mrsabath
mrsabath approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @lumjjb for this update. This works great! More documentation updates to follow.

lumjjb
lumjjb commented Feb 17, 2022
View reviewed changes
Copy link
Collaborator Author

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, else LGTM

tornjak-backend/api/agent/server.go Outdated Show resolved Hide resolved
tornjak-backend/api/manager/server.go Outdated Show resolved Hide resolved
@mrsabath
Removed empty line
a46527e 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath
Updated debugging
fa9c0fc 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
lumjjb
lumjjb commented Feb 18, 2022
View reviewed changes
tornjak-backend/api/manager/server.go Show resolved Hide resolved
tornjak-backend/api/manager/server.go Outdated Show resolved Hide resolved
tornjak-backend/api/agent/server.go Outdated Show resolved Hide resolved
@mrsabath
Post review updates
7838cb1 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath
Removed the backoff downgrade
5f49620 
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath merged commit efb4acb into main Mar 1, 2022
@mrsabath mrsabath deleted the add-agent-tls-ca-opt branch March 1, 2022 21:24
@lumjjb lumjjb changed the title [WIP] Add mTLS CA Option on tornjak server Add mTLS CA Option on tornjak server Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsabath mrsabath mrsabath approved these changes

Assignees

@mrsabath mrsabath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumjjb @mrsabath