Add new SPIRE APIs with versioning and plurality #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Xiaocao-Cxh
requested review from
lumjjb,
mrsabath,
mamy-CS and
maia-iyer
as code owners
maia-iyer
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Hello thank you for your contributions! I left one minor comment to group the v1 apis together
Another note: PR title common style usually comes of the form "Add versioning and plurality" - so capitalized, and in present tense. I will edit it to have more detail
maia-iyer
changed the title
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.