Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPIRE Bundle APIs #478

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Add SPIRE Bundle APIs #478

merged 5 commits into from
Aug 13, 2024

Conversation

maia-iyer
Copy link
Collaborator

closes #474

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added backend Tornjak API (Backend) go Pull requests that update Go code labels Aug 7, 2024
@maia-iyer maia-iyer added this to the 1.8.0 milestone Aug 7, 2024
@maia-iyer maia-iyer self-assigned this Aug 7, 2024
@maia-iyer maia-iyer marked this pull request as ready for review August 7, 2024 18:50
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Copy link
Collaborator

@mamy-CS mamy-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these APIs, lgtm!

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer merged commit 243788e into dev Aug 13, 2024
8 checks passed
@maia-iyer maia-iyer deleted the bundle_apis branch August 13, 2024 14:23
@maia-iyer maia-iyer mentioned this pull request Sep 9, 2024
maia-iyer added a commit that referenced this pull request Sep 17, 2024
* Add bundle functions

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* add v1 apis

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* format nit

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Nit uri fix

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* gofmtted code

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

---------

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer added a commit that referenced this pull request Sep 17, 2024
* Add bundle functions

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* add v1 apis

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* format nit

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Nit uri fix

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* gofmtted code

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

---------

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) go Pull requests that update Go code Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SPIRE bundle APIs
2 participants