Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for RBAC package #490

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

Xiaocao-Cxh
Copy link
Contributor

Added rbac tests as discussed on Tuesday meeting Sep 3.

Xuhang Cao added 3 commits September 3, 2024 18:22
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these tests! my only comment is that the errors may change slightly within the next couple versions, so let's make the error checks slightly more general

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! It looks like you need to import the "strings" library. Be sure to test with go test!

Xuhang Cao added 2 commits September 13, 2024 15:38
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
@maia-iyer maia-iyer changed the title Rbac test Added unit tests for RBAC package Sep 16, 2024
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

@maia-iyer maia-iyer merged commit 4ffbb4b into spiffe:dev Sep 16, 2024
2 checks passed
maia-iyer pushed a commit that referenced this pull request Sep 17, 2024
* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Changed error messages

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Imported strings

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Imported strings

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

---------

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer pushed a commit that referenced this pull request Sep 17, 2024
* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Start writing rbac tests

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Changed error messages

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Imported strings

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

* Imported strings

Signed-off-by: Xuhang Cao <ccao@oberlin.edu>

---------

Signed-off-by: Xuhang Cao <65797697+Xiaocao-Cxh@users.noreply.github.com>
@Xiaocao-Cxh Xiaocao-Cxh deleted the rbacTest branch October 1, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants