-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for RBAC package #490
Conversation
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these tests! my only comment is that the errors may change slightly within the next couple versions, so let's make the error checks slightly more general
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! It looks like you need to import the "strings" library. Be sure to test with go test
!
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you!
* Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Changed error messages Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
* Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Changed error messages Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <65797697+Xiaocao-Cxh@users.noreply.github.com>
Added rbac tests as discussed on Tuesday meeting Sep 3.