[Tornjak-frontend] Clean up error handling #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumjjb
reviewed
Apr 2, 2022
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
add comments to create section for all the error handling stuff
| {this.props.globalErrorMessage} | ||
| </pre> | ||
| </div> | ||
| <InlineNotification kind="error" title="Error" subtitle={this.props.globalErrorMessage} /> |
There was a problem hiding this comment.
probably once this gets fleshed out to abstract into its own error class since it will need to be repeated elsewhere.
mrsabath
force-pushed
the
torkjak-frontend-8-clean-up-error-handling
branch
from
fdf6bab to
f16a73a
Compare
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
zilosz
force-pushed
the
torkjak-frontend-8-clean-up-error-handling
branch
from
5ba9235 to
284f9d4
Compare
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
…e later Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Signed-off-by: Aura6 <aura1391215@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 UI ways to show an error to the user and a set of functions to show debugs for developers.