Backend auth #65
Merged
Backend auth #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer
force-pushed
the
backend-auth
branch
from
61b3810 to
d0d019d
Compare
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mrsabath
reviewed
Sep 23, 2022
mrsabath
reviewed
Sep 23, 2022
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer
force-pushed
the
backend-auth
branch
from
d472fae to
d09d207
Compare
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
lumjjb
reviewed
Oct 2, 2022
| rtr.HandleFunc("/api/agent/list", s.agentList) | ||
| rtr.HandleFunc("/api/agent/ban", s.agentBan) | ||
| rtr.HandleFunc("/api/agent/delete", s.agentDelete) | ||
| rtr.HandleFunc("/api/agent/createjointoken", s.agentCreateJoinToken) |
There was a problem hiding this comment.
im assuming now that its serving from the same domain / server that CORS policy isnt required and that's why its removed yea? or was in put in a different way?
There was a problem hiding this comment.
Yes so I added middleware for the authorization function, and I put the CORS handler there
| api_permissions["/api/tornjak/selectors/register"] = []string{"admin"} | ||
| api_permissions["/api/tornjak/clusters/create"] = []string{"admin"} | ||
| api_permissions["/api/tornjak/clusters/edit"] = []string{"admin"} | ||
| api_permissions["/api/tornjak/clusters/delete"] = []string{"admin"} |
There was a problem hiding this comment.
can we have this be part of a map defined instead so it's easier to view, and also we don't have to initialize it each time
There was a problem hiding this comment.
@lumjjb we will be externalizing it into a config file as a separate effort, lead by our intern. Let's leave this as is for now.
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer
force-pushed
the
backend-auth
branch
from
79b4a53 to
0c8844a
Compare
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For early review. Backend implementation for #63 Currently in progress: