Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Modules #220

Merged
merged 3 commits into from
Apr 9, 2021
Merged

ES Modules #220

merged 3 commits into from
Apr 9, 2021

Conversation

spiltcoffee
Copy link
Owner

What issues is this pull request related to?

#219

What changes were made in this pull request?

  • feat: bumped minimum node version to 12.0.0 (to support esmodule conversion)
  • fix: fixed tsconfig.json
    • updated module to esnext
    • removed lib
  • feat: updated all of postdfm to use esmodules correctly

BREAKING CHANGES

  • minimum node version is now 12.0.0
  • postdfm is now using esmodules instead of commonjs

@spiltcoffee
feat: bumped minimum node version to 12.0.0
d9f4ea4 
Bumping to support esmodule conversion

BREAKING CHANGE: bumped minimum node version to 12.0.0
@spiltcoffee
fix: fixed tsconfig.json
e91b50a 
updated `module` to `esnext`, removed `lib`

BREAKING CHANGE: postdfm is now in ESM rather than CommonJS

fix #219
@spiltcoffee spiltcoffee force-pushed the esmodules branch 2 times, most recently from 4a70e31 to 1090470 Compare April 8, 2021 23:40
@codecov
Copy link

codecov bot commented Apr 8, 2021 •
edited
Loading

Codecov Report

Merging #220 (7713eec) into main (94df2f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #220    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           37        33     -4     
  Lines          412       309   -103     
  Branches        51        56     +5     
==========================================
- Hits           412       309   -103
Impacted Files Coverage Δ
packages/@postdfm/dfm2ast/src/index.ts 100.00% <100.00%> (ø)
packages/postdfm/src/index.ts 100.00% <100.00%> (ø)
packages/@postdfm/ast/src/item.ts 100.00% <0.00%> (ø)
packages/@postdfm/ast/src/root.ts 100.00% <0.00%> (ø)
packages/@postdfm/ast/src/object.ts 100.00% <0.00%> (ø)
packages/@postdfm/ast/src/astNode.ts 100.00% <0.00%> (ø)
packages/@postdfm/ast/src/property.ts 100.00% <0.00%> (ø)
packages/@postdfm/plugin/src/hooks.ts 100.00% <0.00%> (ø)
packages/@postdfm/ast/src/list/list.ts 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94df2f4...7713eec. Read the comment docs.

@spiltcoffee
Copy link
Owner Author

Running into sporadic test failures between two sets of tests using dynamic imports.
Relevant issue: jestjs/jest#10944

@spiltcoffee spiltcoffee changed the title Esmodules ES Modules Apr 9, 2021
@spiltcoffee
Copy link
Owner Author

Appear to have addressed the sporadic test failure: jestjs/jest#10944 (comment)

@spiltcoffee spiltcoffee merged commit c83aa08 into main Apr 9, 2021
@spiltcoffee spiltcoffee deleted the esmodules branch April 9, 2021 12:30
@spiltcoffee
Copy link
Owner Author

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spiltcoffee